Skip to content

Change Signposter 'Homeserver' performance tag to 'homeserver'#5128

Merged
manuroe merged 2 commits into
mainfrom
manuroe/ex_metrics_refinements
Feb 20, 2026
Merged

Change Signposter 'Homeserver' performance tag to 'homeserver'#5128
manuroe merged 2 commits into
mainfrom
manuroe/ex_metrics_refinements

Conversation

@manuroe

@manuroe manuroe commented Feb 20, 2026

Copy link
Copy Markdown
Member

The spec was misleading. We fixed it in element-hq/element-meta#3132.

@manuroe manuroe requested a review from a team as a code owner February 20, 2026 14:58
@manuroe manuroe added the pr-misc for other changes label Feb 20, 2026
@manuroe manuroe requested review from stefanceriu and removed request for a team February 20, 2026 14:58

@jmartinesp jmartinesp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my iOS developer hat on, this LGTM (although it won't unblock merging the PR 😅)!

@codecov

codecov Bot commented Feb 20, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1162 2 1160 0
View the top 1 failed test(s) by shortest run time
UserSessionFlowCoordinatorTests::testRoomPresentation()
Stack Traces | 0.468s run time
XCTAssertTrue failed (UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:90)
View the full list of 1 ❄️ flaky test(s)
ChatsTabFlowCoordinatorTests::testShareTextRouteWithRoom()

Flake rate in main: 32.48% (Passed 79 times, Failed 38 times)

Stack Traces | 12.3s run time
XCTAssertTrue failed (UnitTests/Sources/ChatsTabFlowCoordinatorTests.swift:267)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Velin92 Velin92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there seems to be something wrong with swiftlint and swiftformat, maybe update them and run them again

@manuroe manuroe merged commit c7ef24d into main Feb 20, 2026
6 checks passed
@manuroe manuroe deleted the manuroe/ex_metrics_refinements branch February 20, 2026 16:56
pixlwave pushed a commit that referenced this pull request Feb 25, 2026
* Signposter: Change 'Homeserver' performance tag to 'homeserver'

The spec was misleading. We fixed it in element-hq/element-meta#3132.
@pixlwave

pixlwave commented Feb 25, 2026

Copy link
Copy Markdown
Member

Seems this accidentally targeted main so I've cherry-picked it to develop as 61c3262

pixlwave pushed a commit that referenced this pull request Feb 25, 2026
* Signposter: Change 'Homeserver' performance tag to 'homeserver'

The spec was misleading. We fixed it in element-hq/element-meta#3132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-misc for other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants