Skip to content

Signposter and sentry metrics update#5020

Merged
stefanceriu merged 3 commits into
developfrom
stefan/signposter
Jan 30, 2026
Merged

Signposter and sentry metrics update#5020
stefanceriu merged 3 commits into
developfrom
stefan/signposter

Conversation

@stefanceriu

@stefanceriu stefanceriu commented Jan 29, 2026

Copy link
Copy Markdown
Member

This set of commits refactor how we gather sentry metrics

As per element-hq/element-meta#3055

@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.33708% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.76%. Comparing base (e06baf6) to head (2fe33e0).
⚠️ Report is 16 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 32 Missing ⚠️
...ementX/Sources/Services/Analytics/Signposter.swift 44.18% 24 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 3 Missing ⚠️
ElementX/Sources/Other/SDKListener.swift 0.00% 2 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5020      +/-   ##
===========================================
- Coverage    79.42%   78.76%   -0.67%     
===========================================
  Files          907      907              
  Lines        67745    68844    +1099     
===========================================
+ Hits         53806    54223     +417     
- Misses       13939    14621     +682     
Flag Coverage Δ
unittests 71.65% <30.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu added the pr-misc for other changes label Jan 29, 2026
@stefanceriu stefanceriu marked this pull request as ready for review January 29, 2026 09:41
@stefanceriu stefanceriu requested a review from a team as a code owner January 29, 2026 09:41
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team January 29, 2026 09:41
Comment thread ElementX/Sources/Application/Settings/AppSettings.swift Outdated
@stefanceriu stefanceriu merged commit a2a8527 into develop Jan 30, 2026
11 checks passed
@stefanceriu stefanceriu deleted the stefan/signposter branch January 30, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-misc for other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants