Skip to content

Add check on merged manifest#7172

Open
bmarty wants to merge 7 commits into
developfrom
feature/bma/mergedManifest
Open

Add check on merged manifest#7172
bmarty wants to merge 7 commits into
developfrom
feature/bma/mergedManifest

Conversation

@bmarty

@bmarty bmarty commented Jul 8, 2026

Copy link
Copy Markdown
Member

Content

Add a check on aapt dump result to track possibly hidden changes in the merged AndroidManifest.

Also update release script, which change the version of the application and the job which sync Localazy as it can add new locales and so break this file too.

Motivation and context

Closes #6978

Screenshots / GIFs

Tests

Tested devices

  • NA

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TAxc4N

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (6124d99) to head (2e16191).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7172   +/-   ##
========================================
  Coverage    80.55%   80.55%           
========================================
  Files         2711     2711           
  Lines        78168    78168           
  Branches     10557    10557           
========================================
  Hits         62969    62969           
  Misses       11126    11126           
  Partials      4073     4073           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bmarty and others added 4 commits July 8, 2026 14:12
New locales added via Localazy would change the locales line in
aaptDump.txt and break the manifest CI check if the reference file
is not kept in sync.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bmarty bmarty marked this pull request as ready for review July 8, 2026 12:44
@bmarty bmarty requested a review from a team as a code owner July 8, 2026 12:44
@bmarty bmarty requested review from jmartinesp and removed request for a team July 8, 2026 12:44
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Build For changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add checks on merged manifest

1 participant