Skip to content

Cleanup AndroidManifest.xml files.#7171

Merged
bmarty merged 2 commits into
developfrom
feature/bma/cleanUpManifest
Jul 8, 2026
Merged

Cleanup AndroidManifest.xml files.#7171
bmarty merged 2 commits into
developfrom
feature/bma/cleanUpManifest

Conversation

@bmarty

@bmarty bmarty commented Jul 8, 2026

Copy link
Copy Markdown
Member

Content

Cleanup AndroidManifest.xml files.

Motivation and context

Ensure permission are declared in the modules that uses it.

Screenshots / GIFs

Tests

  • No expected impact

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner July 8, 2026 11:11
@bmarty bmarty requested review from jmartinesp and removed request for a team July 8, 2026 11:11
@bmarty bmarty added the PR-Misc For other changes label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oQAEfv

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (6124d99) to head (3dabece).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7171   +/-   ##
========================================
  Coverage    80.55%   80.55%           
========================================
  Files         2711     2711           
  Lines        78168    78168           
  Branches     10557    10557           
========================================
  Hits         62969    62969           
  Misses       11126    11126           
  Partials      4073     4073           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty enabled auto-merge July 8, 2026 15:32
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@bmarty bmarty merged commit 3642065 into develop Jul 8, 2026
31 of 32 checks passed
@bmarty bmarty deleted the feature/bma/cleanUpManifest branch July 8, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants