Handle local network permission - Android 17#7165
Open
ganfra wants to merge 8 commits into
Open
Conversation
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
5 tasks
Member
a9b7b6f to
f25ca5b
Compare
Member
Author
|
ElementBot
reviewed
Jul 8, 2026
| permissionsPresenterFactory: PermissionsPresenter.Factory, | ||
| ) : Presenter<LoggedInState> { | ||
| private val localNetworkPermissionsPresenter: PermissionsPresenter = | ||
| permissionsPresenterFactory.create(Manifest.permission.ACCESS_LOCAL_NETWORK) |
Collaborator
There was a problem hiding this comment.
⚠️ Field requires API level 37 (current min is 33):android.Manifest.permission#ACCESS_LOCAL_NETWORK
| permissionsPresenterFactory: PermissionsPresenter.Factory, | ||
| ) { | ||
| private val permissionsPresenter: PermissionsPresenter = | ||
| permissionsPresenterFactory.create(Manifest.permission.ACCESS_LOCAL_NETWORK) |
Collaborator
There was a problem hiding this comment.
⚠️ Field requires API level 37 (current min is 33):android.Manifest.permission#ACCESS_LOCAL_NETWORK
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7165 +/- ##
===========================================
- Coverage 80.53% 80.51% -0.03%
===========================================
Files 2705 2714 +9
Lines 78030 78270 +240
Branches 10532 10582 +50
===========================================
+ Hits 62843 63016 +173
- Misses 11128 11174 +46
- Partials 4059 4080 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Content
Android 17 introduces a new runtime permission for reaching local-network addresses. Without it, TCP connections to local IPs silently time out.
How it works
Also
variants instead of the built-in PermissionsView.
Motivation and context
Closes #7073
Screenshots / GIFs
Tests
Tested devices
Checklist