Add programmatic label and focus indicator to PIN entry field#7132
Add programmatic label and focus indicator to PIN entry field#7132bmarty wants to merge 6 commits into
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7132 +/- ##
========================================
Coverage 80.54% 80.55%
========================================
Files 2689 2689
Lines 76433 76448 +15
Branches 10291 10291
========================================
+ Hits 61566 61582 +16
Misses 10933 10933
+ Partials 3934 3933 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5fe8a37 to
bf1ace4
Compare
|
| if (isFocused) { | ||
| Modifier.border(2.dp, ElementTheme.colors.borderFocused, shape) | ||
| } else { | ||
| Modifier.border(1.dp, ElementTheme.colors.iconPrimary, shape) |
There was a problem hiding this comment.
Is it provided by design? Looks like we don't see the border color in Light them?
|
@gaelledel I have made a proposal in this PR, can you validate that it's fine for you? The current to-be-entered digit has a border color @ganfra the preview is not reliable, but it works in light theme in the app. |



Summary
contentDescriptiontoPinEntryTextField'sBasicTextFieldso TalkBack announces the field label and how many digits have been entered (fixes A11y: [Choose PIN] PIN input fields lack programmatically associated ... #6391)ElementTheme.colors.borderInteractiveHovered) toPinEntryRowwhen the field has focus (fixes A11y: [Choose PIN] PIN input field has no visible keyboard focus indi... #6401)The current digit will have an highlight border:
Test plan