Skip to content

Add programmatic label and focus indicator to PIN entry field#7132

Open
bmarty wants to merge 6 commits into
developfrom
fix/a11y-pin-screen
Open

Add programmatic label and focus indicator to PIN entry field#7132
bmarty wants to merge 6 commits into
developfrom
fix/a11y-pin-screen

Conversation

@bmarty

@bmarty bmarty commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

The current digit will have an highlight border:

image

Test plan

  • Open the PIN setup/entry screen with TalkBack enabled — verify the field is announced as "PIN field, N digit(s) entered"
  • Navigate to the PIN field with a keyboard — verify a visible focus border appears around the digit row

…y field

Fixes: #6391
Fixes: #6401

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bmarty bmarty requested a review from a team as a code owner July 1, 2026 16:04
@bmarty bmarty removed the request for review from a team July 1, 2026 16:04
@bmarty bmarty added the PR-Bugfix For bug fix label Jul 1, 2026
@bmarty bmarty requested a review from ganfra July 1, 2026 16:04
@bmarty bmarty marked this pull request as draft July 1, 2026 16:06
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Sr2cEK

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (58b3830) to head (bad39d6).
⚠️ Report is 100 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7132   +/-   ##
========================================
  Coverage    80.54%   80.55%           
========================================
  Files         2689     2689           
  Lines        76433    76448   +15     
  Branches     10291    10291           
========================================
+ Hits         61566    61582   +16     
  Misses       10933    10933           
+ Partials      3934     3933    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 2, 2026
@github-actions github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 2, 2026
@bmarty bmarty force-pushed the fix/a11y-pin-screen branch from 5fe8a37 to bf1ace4 Compare July 2, 2026 13:39
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 3, 2026
@github-actions github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 3, 2026
@bmarty bmarty marked this pull request as ready for review July 3, 2026 09:16
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Comment on lines +106 to +109
if (isFocused) {
Modifier.border(2.dp, ElementTheme.colors.borderFocused, shape)
} else {
Modifier.border(1.dp, ElementTheme.colors.iconPrimary, shape)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it provided by design? Looks like we don't see the border color in Light them?

@bmarty

bmarty commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@gaelledel I have made a proposal in this PR, can you validate that it's fine for you? The current to-be-entered digit has a border color borderFocused (see the screenshot in the PR description).

@ganfra the preview is not reliable, but it works in light theme in the app.

@bmarty bmarty requested a review from gaelledel July 6, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A11y: [Choose PIN] PIN input field has no visible keyboard focus indi... A11y: [Choose PIN] PIN input fields lack programmatically associated ...

3 participants