Skip to content

Get enterprise modules if secret is available instead of always skipping on forks.#7118

Draft
bmarty wants to merge 5 commits into
developfrom
feature/bma/buildEnterprise
Draft

Get enterprise modules if secret is available instead of always skipping on forks.#7118
bmarty wants to merge 5 commits into
developfrom
feature/bma/buildEnterprise

Conversation

@bmarty

@bmarty bmarty commented Jun 29, 2026

Copy link
Copy Markdown
Member

Content

Get enterprise modules if secret is available instead of always skipping on forks.

Motivation and context

Let forks that have a deploy key secret be able to build enterprise application.

Screenshots / GIFs

NA

Tests

Tested devices

  • NA

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3ouJwv

@bmarty bmarty marked this pull request as ready for review June 29, 2026 14:57
@bmarty bmarty requested a review from a team as a code owner June 29, 2026 14:57
@bmarty bmarty requested review from ganfra and removed request for a team June 29, 2026 14:57
@bmarty bmarty force-pushed the feature/bma/buildEnterprise branch from 13e065e to da85c5f Compare July 1, 2026 12:32
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.54%. Comparing base (b875215) to head (34a233d).
⚠️ Report is 113 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7118   +/-   ##
========================================
  Coverage    80.54%   80.54%           
========================================
  Files         2689     2689           
  Lines        76433    76433           
  Branches     10291    10291           
========================================
  Hits         61566    61566           
  Misses       10933    10933           
  Partials      3934     3934           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty

bmarty commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

This PR is now OK, but a PR from a fork which have the expected secret (on their side) cannot use it. It seems that the secret is not shared with upstream, which actually makes sense. See Run echo "has_key=false" >> $GITHUB_OUTPUT at https://github.com/element-hq/element-x-android/actions/runs/28518405517/job/84535883807?pr=7119.

@bmarty bmarty marked this pull request as draft July 6, 2026 14:21
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants