WIP : Set user status by ganfra · Pull Request #7094 · element-hq/element-x-android

ganfra · 2026-06-24T17:06:16Z

Content

Start implementing the set user status part, but using only in-memory data (no sdk yet).
So this is mostly design work.
What is missing :

branching sdk
managing emoji picker

Motivation and context

Handles part of
#6877
#6878
#6879

Screenshots / GIFs

See recorded screenshots.

Tests

Open settings
Enable related feature flag
You should see the "What's your status?" item at the top of the Settings screen.
Keep in mind the data is only in-memory for now.

Tested devices

Physical
Emulator
OS version(s):

Checklist

github-actions · 2026-06-24T17:17:02Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iqz8n2

…rStatusView

…ext presence

…in-width

…in view

…ith TextField row

codecov · 2026-06-25T11:33:32Z

Codecov Report

❌ Patch coverage is 84.02367% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.63%. Comparing base (a373678) to head (301f930).
⚠️ Report is 129 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ures/preferences/impl/userstatus/UserStatusView.kt	82.51%	7 Missing and 18 partials ⚠️
.../android/libraries/matrix/impl/RustMatrixClient.kt	21.05%	14 Missing and 1 partial ⚠️
...preferences/impl/userstatus/UserStatusPresenter.kt	90.90%	0 Missing and 3 partials ⚠️
...braries/designsystem/theme/components/TextField.kt	92.85%	1 Missing and 2 partials ⚠️
...nces/impl/userstatus/UserStatusBindingContainer.kt	0.00%	2 Missing ⚠️
.../android/libraries/matrix/test/FakeMatrixClient.kt	87.50%	0 Missing and 2 partials ⚠️
.../preferences/impl/root/PreferencesRootPresenter.kt	75.00%	0 Missing and 1 partial ⚠️
...tures/preferences/impl/root/PreferencesRootView.kt	92.30%	0 Missing and 1 partial ⚠️
...droid/libraries/matrix/api/user/DisplayedStatus.kt	80.00%	1 Missing ⚠️
...nt/android/libraries/matrix/api/user/UserStatus.kt	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7094      +/-   ##
===========================================
+ Coverage    80.62%   80.63%   +0.01%     
===========================================
  Files         2686     2694       +8     
  Lines        76354    76687     +333     
  Branches     10269    10317      +48     
===========================================
+ Hits         61557    61836     +279     
- Misses       10866    10892      +26     
- Partials      3931     3959      +28

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bmarty

Thanks, tested OK

bmarty · 2026-07-06T10:31:08Z

+                modifier = Modifier.padding(vertical = 16.dp),
+            )
+        },
+        trailingContent = ListItemContent.Custom({


This trailing content is empty, could be removed.

bmarty · 2026-07-06T10:38:29Z

+
+@ContributesTo(SessionScope::class)
+@BindingContainer
+interface UserStatusBindingContainer {


Our current convention is to name this class UserStatusModule. But maybe we should change the convention (probably tight to the old DI API) and rename the other interfaces at some point.

Yeah, I don't have strong opinion, I can use Module and we make the change later on the whole codebase

Let's keep it like this then, and rename the other ones separately

bmarty · 2026-07-06T10:45:30Z

+    fun `initial state - no status set`() = runTest {
+        moleculeFlow(RecompositionMode.Immediate) {
+            createPresenter().present()
+        }.test {


Use test extension?

bmarty · 2026-07-06T10:47:29Z

    override suspend fun getUserProfile(): Result<MatrixUser> = getProfile(sessionId)
        .onSuccess { matrixUser ->
-            _userProfile.emit(matrixUser)
-            // Also update our session storage


Why removing this comment? It does not add much value but still should not be removed.

I don't like obvious comment like this :)

sonarqubecloud · 2026-07-08T16:28:38Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ganfra added PR-Wip For anything that isn't ready to ship and will be enabled at a later date Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Jun 24, 2026

github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 24, 2026

ganfra added 26 commits June 25, 2026 12:32

Add UserStatus and DisplayedStatus types to matrix API

bad32cb

Add KDoc to InCall.callJoinedTs and clearUserStatus

5697c96

Add setUserStatus/clearUserStatus stubs to FakeMatrixClient

742902e

Stub setUserStatus/clearUserStatus in-memory in RustMatrixClient

f4c79be

Add user status string resources and PredefinedUserStatus enum

42966b3

Fix thread-safety and dispatcher consistency in user status stubs

1640adc

Add UserStatusState and UserStatusEvent

eca45b5

Add UserStatusPresenter with full test coverage

0528b78

Add UserStatusView composables with previews

af5a237

Wire UserStatusPresenter and UserStatusRow into PreferencesRoot

6c34d64

Wire UserStatusPresenter and UserStatusRow into PreferencesRoot

7309e49

Move custom status emoji/text into CustomInput state (MVI)

eeaaac2

Use TextFieldState in CustomInput state for proper MVI text handling

73a8a3d

Add TextFieldState overload to design system TextField, use it in Use…

57617a3

…rStatusView

Add clear button in custom status text field, toggle Cancel/Save on t…

167c1ce

…ext presence

Fix button width jitter using rememberTextMeasurer to derive stable m…

889fd08

…in-width

Move preview cases to UserStatusStateProvider, use @PreviewParameter …

078b63f

…in view

Match row heights: add vertical padding to plain text rows to align w…

2a0e416

…ith TextField row

Rename Event

553a478

Improve UI/UX for setting status

1cfd3e4

Gate user status behind UserStatus feature flag

dd24e14

Extract custom status text max length into a constant

d29dad4

Clip avatar to a circle on the user status screen

061fd82

Move user status section below multi-account in preferences

be872e6

Format code

4a143c1

Address quality issues on user status

29b8068

ganfra force-pushed the feature/fga/set_user_status branch from a6c7ee9 to 29b8068 Compare June 25, 2026 10:33

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 25, 2026

github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 25, 2026

Update screenshots

f9a8acf

ganfra marked this pull request as ready for review June 25, 2026 13:29

ganfra requested a review from a team as a code owner June 25, 2026 13:29

ganfra requested review from bmarty and removed request for a team June 25, 2026 13:29

Tweak some UserStatusView ui

bfe2169

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 2, 2026

github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 2, 2026

Update screenshots

301f930

bmarty approved these changes Jul 6, 2026

View reviewed changes

ganfra added 2 commits July 8, 2026 17:59

Merge branch 'develop' into feature/fga/set_user_status

d25362d

Address PR review comments

fad8dce

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 8, 2026

ganfra enabled auto-merge July 8, 2026 16:17

github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP : Set user status#7094

WIP : Set user status#7094
ganfra wants to merge 31 commits into
developfrom
feature/fga/set_user_status

ganfra commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

bmarty left a comment

Uh oh!

bmarty Jul 6, 2026

Uh oh!

bmarty Jul 6, 2026

Uh oh!

ganfra Jul 6, 2026

Uh oh!

bmarty Jul 6, 2026

Uh oh!

bmarty Jul 6, 2026

Uh oh!

bmarty Jul 6, 2026

Uh oh!

ganfra Jul 6, 2026

Uh oh!

sonarqubecloud Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ganfra commented Jun 24, 2026

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

github-actions Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

bmarty Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

bmarty Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

ganfra Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

bmarty Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

bmarty Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

bmarty Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

ganfra Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 8, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 24, 2026 •

edited

Loading

codecov Bot commented Jun 25, 2026 •

edited

Loading