Skip to content

Let Divider use our theme color.#7054

Merged
bmarty merged 3 commits into
developfrom
feature/bma/divider
Jun 18, 2026
Merged

Let Divider use our theme color.#7054
bmarty merged 3 commits into
developfrom
feature/bma/divider

Conversation

@bmarty

@bmarty bmarty commented Jun 18, 2026

Copy link
Copy Markdown
Member

Content

Let Divider use color and height from our theme.

Motivation and context

Limit usage of Material color
Help to provide a better fix instead of #7039

Screenshots / GIFs

See tiny diff in the recorded ones

Tests

  • Small UI change

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 18, 2026 14:03
@bmarty bmarty requested review from jmartinesp and removed request for a team June 18, 2026 14:03
@bmarty bmarty added the PR-Misc For other changes label Jun 18, 2026

@jmartinesp jmartinesp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice. Thank you!

@github-actions

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CCEbci

@bmarty bmarty enabled auto-merge June 18, 2026 14:18
@bmarty bmarty merged commit 5ac7d2a into develop Jun 18, 2026
33 of 35 checks passed
@bmarty bmarty deleted the feature/bma/divider branch June 18, 2026 14:40
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.60%. Comparing base (8ca1ce4) to head (d3f0a7e).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7054   +/-   ##
========================================
  Coverage    80.60%   80.60%           
========================================
  Files         2681     2681           
  Lines        76283    76284    +1     
  Branches     10250    10250           
========================================
+ Hits         61486    61487    +1     
  Misses       10872    10872           
  Partials      3925     3925           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mvanhorn added a commit to mvanhorn/element-x-android that referenced this pull request Jun 19, 2026
Following review feedback: now that the global HorizontalDivider uses
separatorSecondary (element-hq#7054), give the Black/OLED theme a visible
separatorSecondary value in ElementTheme instead of carrying a bespoke
listSectionDivider alias. This fixes all separators on pure black, not
just section headers. The exact color is pending design confirmation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants