Let Divider use our theme color.#7054
Merged
Merged
Conversation
And set the thickness to 1.dp
10 tasks
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7054 +/- ##
========================================
Coverage 80.60% 80.60%
========================================
Files 2681 2681
Lines 76283 76284 +1
Branches 10250 10250
========================================
+ Hits 61486 61487 +1
Misses 10872 10872
Partials 3925 3925 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mvanhorn
added a commit
to mvanhorn/element-x-android
that referenced
this pull request
Jun 19, 2026
Following review feedback: now that the global HorizontalDivider uses separatorSecondary (element-hq#7054), give the Black/OLED theme a visible separatorSecondary value in ElementTheme instead of carrying a bespoke listSectionDivider alias. This fixes all separators on pure black, not just section headers. The exact color is pending design confirmation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Let Divider use color and height from our theme.
Motivation and context
Limit usage of Material color
Help to provide a better fix instead of #7039
Screenshots / GIFs
See tiny diff in the recorded ones
Tests
Tested devices
Checklist