WIP: Make PIP react to camera orientation changes#6951
Draft
jmartinesp wants to merge 1 commit into
Draft
Conversation
Adds a `controls.onPipMediaOrientationUpdate` callback for the WebView that will trigger a new `pipParamsBuilder.setAspectRatioFromOrientation(orientation)` method
|
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6951 +/- ##
===========================================
- Coverage 80.98% 80.95% -0.03%
===========================================
Files 2672 2673 +1
Lines 76125 76151 +26
Branches 9976 9983 +7
===========================================
+ Hits 61647 61651 +4
- Misses 10828 10848 +20
- Partials 3650 3652 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
Adds a
controls.onPipMediaOrientationUpdatecallback for the WebView that will trigger a newpipParamsBuilder.setAspectRatioFromOrientation(orientation)method.This should be used along with element-hq/element-call#4004, but we can add the code before that's merged, as the callback just won't be used.
Motivation and context
Adapt to Element Call changes.
Tests
Use https://pr4004--element-call.netlify.app/room to test this.
Tested devices
Checklist