Implement MSC2530#2522
Merged
jmartinesp merged 10 commits intoMar 19, 2024
Merged
Conversation
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Contributor
Author
|
Not convinced about how that column looks like, but it's sunday so I'll keep trying later |
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
added video captions Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Contributor
Author
|
The 'Record Screenshots' action seems be failing but I don't see any error related to this change on its log 🤔 |
Member
|
Thanks for the changes! I'll merge it to a branch of mine where I can tweak these changes a bit so they fit a bit better our layout. |
5b2a45f
into
element-hq:feature/add-caption-to-image-and-video-events
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-rust-sdk#3171
Fixes #2521
Type of change
Content
Show body as image caption, per MSC 2530
Motivation and context
Caption as a different message doesn't look this good
Screenshots / GIFs
Tests
Tested devices
Checklist