Skip to content

Enable more oxlint rules#34189

Draft
t3chguy wants to merge 26 commits into
t3chguy/oxlintfrom
t3chguy/oxlint-follow1
Draft

Enable more oxlint rules#34189
t3chguy wants to merge 26 commits into
t3chguy/oxlintfrom
t3chguy/oxlint-follow1

Conversation

@t3chguy

@t3chguy t3chguy commented Jul 8, 2026

Copy link
Copy Markdown
Member

No description provided.

toger5 and others added 26 commits July 7, 2026 16:09
@toger5 @robintown
Allow disabling legacy calls and make Voice & Video settings `Legac…
1b10122 
…y Voice & Video` (#33692)

* Change `feature_group_calls` to default to true.
Change state to Beta

* Add `enableLegacyCallsVoip` (clarify: Audio settings relate to Legacy)
Change `element_call.use_exclusively` to just be the default of
`enableLegacyCallsVoip`.
Allow disabling in Legacy in the settings. (overwrite `use_exclusivly`
via `enableLegacyCallsVoip`)
Rename `Voice & Video` to `Legacy Voice & Video`

* improvements
 - settings title update to only show legacy when appropriate
 - hide menu all together if use_exclusivly is chosen

* simplify by removing the feature_group_calls flag

* smaller cleanup

* fix tests and cleanup

* clarify settings (disable) in config.md

* add back EC relevant settings in room settings dialog

* update screenshots (now default to EC enabled (not disabled)
-> show voice and video tab in room settings

* update screenshots

* always show option to control voice messages input

* lint

* fix test

* disable -> enabled And only have on mic dropdown

* update config.md

* Back to `disabled` (on by default/no config)

* remove element call hint from voice-video settings

* Update apps/web/src/i18n/strings/en_EN.json

Co-authored-by: Robin <robin@robin.town>

* Update apps/web/src/components/views/settings/tabs/user/VoiceUserSettingsTab.tsx

Co-authored-by: Robin <robin@robin.town>

* review

* cleanup element call url setting (its deprecated/not used anymore)

* clarify, that also jisti will be enabled/disabled by legacy settings
flag

* remove double section

* remove unn exassary element_call configurations

* Update en_EN.json

* Update VoiceUserSettingsTab.tsx

* Make tests use new defaults (enable element call)

* Default events power levels

* format

* review "Enable Legacy voice/video calls" label

* more radical usage of defaults in element_call config.json's

* Update config.json

* Update en_EN.json

* Update RoomSettingsDialog-test.tsx.snap

* Update useRoomCall.tsx

* fix imports

* Update request permission promp to latest designs:
https://www.figma.com/design/aOEkaJtaBmPy058V7uoqVr/Element-Call-Updates---2026?node-id=45-12591&t=7takL39icZwt9YjL-0

* Update config.json.d.ts

* fix usage of `Element` in i18n

* Update General-room-settings-tab-should-be-rendered-properly-1-linux.png

---------

Co-authored-by: Robin <robin@robin.town>
@MidhunSureshR
Implement tombstone tiles for calls in room and DM (#34141)
e46acef 
* Implement tombstone tile view for a room

* Implement tombstone tile view for a DM

* Implement root call tile view

* Export all the views

* Add screenshots

* Remove old view code

* Implement vm for tombstone tile in a room

* Implement vm for tombstone tile in a DM

* Implement root tile vm

* Use new tile in the event factory

* Remove old vm

* Exclude mock code from code checks
@Half-Shot
URL Preview further design iteration (#34054)
ff8abcd 
* Drop unused img

* Fix sizing in bubble layouts

* Update previews

* Update snaps

* fixup

* cleanup

* cleanup
@Half-Shot
Fix composer preview getting stuck on a single module API preview (#3…
38e29c5 
…4173)

* Unset composer preview

* add a test
@t3chguy @github-code-quality
Adapt OAuth2 implementation to Matrix Spec v1.18 (#34026)
2bc9656 
* Adapt OAuth2 implementation to Matrix Spec v1.18

* Handle more cases of oidc->oauth

* Fix test

* Fix read back of oauth2 context

* Iterate

* Fix tests

* Discard changes to apps/web/playwright/e2e/settings/account-user-settings-tab.spec.ts

* Fix test

* Fix test

* Fix test

* Potential fix for pull request finding 'Unused variable, import, function or class'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

* Iterate

* Iterate

* Fix test

---------

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@RiotRobot @t3chguy
[create-pull-request] automated change (#34177)
af881a1 
Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>
@Half-Shot
shared components 0.1.2 (#34175)
8d4ec11
@Half-Shot
module-api 1.15.0 (#34174)
1b3ef74
@dbkr
Center long user ids in the user menu (#34182)
bf1b771 
* Center long user ids in the user menu

The span itself was centered but the text wasn't centered in the span
so long user IDs would be left justified once they wrapped onto two
lines.

* Update screenshot

* Snapshot
@florianduros
RoomList: fix room scroll when clicked in thread activity centre (#34179
d593285 
)

* Make room list handles `show_room_tile` in `Action.ViewRoom`

* Add e2e test to scroll the room list when a room in tac is clicked
@t3chguy
Enable forwardRef oxlint rule
a8fdbc9
@t3chguy
Move more tests from Jest to Vitest (#34181)
67a20c5 
* Move more tests from Jest to Vitest

* Iterate
@t3chguy
Enable no-unused-vars oxlint rule
da80e72
@t3chguy
Enable no-implied-eval oxlint rule
b45225a
@t3chguy
Enable no-duplicate-type-constituents oxlint rule
ba3fb85
@t3chguy
Enable explicit-length-check oxlint rule
2bb0f01
@t3chguy
Enable prefer-number-properties oxlint rule
c7ef92a
@t3chguy
Enable no-callback-in-promise oxlint rule
6c79b23
@t3chguy
Enable no-require-imports oxlint rule
439c3e6
@t3chguy
Remove disablement of most unicorn oxlint rules
8362dc6
@t3chguy
Enable no-conditional-tests oxlint rule
d653c26
@t3chguy
Enable promise-valid-params oxlint rule
59606d4
@t3chguy
Enable require-unicode-regexp oxlint rule
761acf8
@t3chguy
Merge branch 'develop' of ssh://github.com/element-hq/element-web int…
6454090 
…o t3chguy/oxlint-follow1

# Conflicts:
#	apps/web/.eslintrc.cjs
#	apps/web/src/components/structures/MatrixChat.tsx
@t3chguy
Remove max-len comments as we use oxfmt for formatting
59fcb66
@t3chguy
Enable majority of oxlint suspicious rules
014ee77
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Jul 8, 2026
@CLAassistant

CLAassistant commented Jul 8, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ toger5
❌ RiotRobot
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

T-Task Tasks for the team like planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@t3chguy @CLAassistant @toger5 @MidhunSureshR @Half-Shot @RiotRobot @dbkr @florianduros