Avoid snapshot in metaspaces order test#34183
Open
dbkr wants to merge 5 commits into
Open
Conversation
Just assert the thing we're actually testing rather than a snapshot because I keep having to update this snapshot every time anything in the left panel changes and it's tedious.
florianduros
reviewed
Jul 8, 2026
| const { container } = render(<SpacePanel />); | ||
|
|
||
| // Inspect the order of the rendered MetaSpaces, excluding the "Create a space" button. | ||
| const metaSpaceLabels = Array.from(container.querySelectorAll(".mx_SpaceButton:not(.mx_SpaceButton_new)")).map( |
Member
There was a problem hiding this comment.
Can we use instead an accessible attribute to query or a test id attribute instead of relying on the class?
Member
Author
There was a problem hiding this comment.
We can get all the button roles like so?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just assert the thing we're actually testing rather than a snapshot because I keep having to update this snapshot every time anything in the left panel changes and it's tedious.
Checklist
public/exportedsymbols have accurate TSDoc documentation.