Skip to content

Fix joinRoom failing when the roomviewstore state changes.#34180

Open
Half-Shot wants to merge 2 commits into
developfrom
hs/fix-join-rvs
Open

Fix joinRoom failing when the roomviewstore state changes.#34180
Half-Shot wants to merge 2 commits into
developfrom
hs/fix-join-rvs

Conversation

@Half-Shot

Copy link
Copy Markdown
Member

Having investigated this, the bug is that our destructuring in:

const { roomAlias, roomId = payload.roomId, viaServers = [] } = this.state;

does not account for null or other falsey values, which means that this.state.roomId = null takes precedence over payload.roomId.

Checklist

@Half-Shot Half-Shot requested a review from a team as a code owner July 8, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant