Switch from eslint to oxlint#34166
Conversation
…o t3chguy/oxlint # Conflicts: # apps/web/src/components/structures/MatrixChat.tsx # apps/web/src/components/views/elements/PersistedElement.tsx
|
🐂 Had a quick look and this all seems plausible. Do we still need/want a common set of matrix.org rules for oxlint like we had in eslint (I saw the import being removed) or are they sensible enough out of the box? |
|
I think we should lean towards out of the box with some minor tweaks to not need to make our codebase comply on day dot, i.e the approach we adopted with Prettier (now oxfmt). It is better to have something good and consistent rather than tweaking a hundred rules to make it "perfect" for us. |
|
EC has recently also switched to the OX tools. The only thing we kept from the shared repo was the copyright rule. We just copied that one into our repo though to avoid the dependency. Otherwise, agree that there's probably not much benefit in fixating all the various rules across repositories. |
|
Yeah that is a good point, I may adopt that into this monorepo |
|
Or actually, may just nab it from EC :P |
|
Nabbed |
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Makes sense to me: if we can get away without custom rules, let's absolutely do that.
…o t3chguy/oxlint # Conflicts: # apps/web/.eslintrc.cjs # apps/web/src/components/structures/MatrixChat.tsx
3 participants
For https://github.com/element-hq/wat-internal/issues/498
Some of the rules behave differently, some even a touch buggy, but for the insane speed benefit I think it is worth it. Some rules have been disabled in the initial PR but will be followed up in additional PRs to finish off this work.