RoomList: add back Favourites and Low Priority filters when sections are disabled#34162
Merged
Merged
Conversation
florianduros
added
T-Enhancement
T-Feature
florianduros
force-pushed
the
florianduros/favourite-low-prio-filter
branch
from
8bb70e3 to
952aad5
Compare
t3chguy
approved these changes
Jul 7, 2026
gaelledel
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #34147
When
RoomList.showSectionsis off, the room list renders as a flat list with no way to isolate favourite or low-priority rooms. This brings back the Favourites and Low Priority primary filter chips (present before sections shipped) so those rooms can still be filtered. When sections are enabled the chips stay hidden, since sections already surface those rooms.FilterId(shared-components): re-added"favourite"and"low_priority", restoring the original filter order.RoomListPrimaryFilters: added thefavourite/low_prioritylabel cases plus theroom_list|filters|*i18n strings.RoomListViewModel: added both filters tofilterKeyToIdMap; a newgetVisibleFilterIds()omits them when sections are enabled. The VM now watchesRoomList.showSectionsand, since toggling is rare, does a full reset on change — clears the active filter, refetches rooms, and recomputes the visible chips.Screen.Recording.2026-07-07.at.12.22.34.mov