Make the Unreads filter obey the 'Notifications.showbold' setting#34128
Open
andybalaam wants to merge 7 commits into
Open
Make the Unreads filter obey the 'Notifications.showbold' setting#34128andybalaam wants to merge 7 commits into
andybalaam wants to merge 7 commits into
Conversation
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
94cd106 to
927dcec
Compare
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
927dcec to
0a8ace2
Compare
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
0a8ace2 to
6914ad4
Compare
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
6914ad4 to
aaf2f9d
Compare
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
aaf2f9d to
445257d
Compare
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
445257d to
880bbb4
Compare
This is based on #32902 but I chatted with Danielle and we thought that maybe the second checkbox was not needed: if the user chose "Show all activity in the room list (dots or number of unread messages)" then I argue that the user wants to see rooms with dots when they turn on the Unreads filter.
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
880bbb4 to
edd7ba5
Compare
andybalaam
force-pushed
the
andybalaam/unread-filter-obeys-showbold
branch
from
edd7ba5 to
5dc75f2
Compare
Contributor
|
I think this is an improvement, we've talked before about having an extra toggle but seeing this video I don't think it's needed... we could certainly start with this enhancement and then add it later if folks get confused or ask for them to be separated. @gaelledel worked on the design and these toggles so I've asked for a quick check there, otherwise, lgtm! |
florianduros
reviewed
Jul 7, 2026
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #32902 but I chatted with Danielle and we thought that maybe the second checkbox was not needed: if the user chose "Show all activity in the room list (dots or number of unread messages)" then I argue that the user wants to see rooms with dots when they turn on the Unreads filter.
obey-showbold.mp4
Checklist
public/exportedsymbols have accurate TSDoc documentation.