Make notification settings copy/layout more user-friendly#34120
Draft
mxandreas wants to merge 1 commit into
Draft
Make notification settings copy/layout more user-friendly#34120mxandreas wants to merge 1 commit into
mxandreas wants to merge 1 commit into
Conversation
Member
Author
|
@amshakal @daniellekirkwood Could you please have a look at these updates. One specific style-question I have is whether we should use "Mention" or "@mention"? I have slight preference for "@mention" as I think it is then easier to understand and it is consistent with @room which we are already using. Account settings current: 
Account settings new: 
Room settings current: 
Room settings new: |
Member
|
I agree with @mention, it makes it clearer. Other than that, makes sense to me. |
Contributor
|
yep, agreed. this feels like an improvement given our current constraints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some low-hanging fruit updates to the copy and layout of the notification settings, so it would be better understood by users, closer to the copy on EX and also would highlight things which are commonly used by most users, e.g. keywords vs. replies.
It is currently a draft PR just to preview and approve the updates (the copy updates need to go via Localazy).
Checklist
public/exportedsymbols have accurate TSDoc documentation.