Show user status in timeline#32991
Merged
Merged
Conversation
ZacksBot
reviewed
Mar 31, 2026
dbkr
reviewed
Apr 27, 2026
| expect(screen.getByText("Early previews")).toBeInTheDocument(); | ||
| const labsSections = container.getElementsByClassName("mx_SettingsSubsection"); | ||
| expect(labsSections).toHaveLength(8); | ||
| expect(labsSections).toHaveLength(9); |
Member
There was a problem hiding this comment.
I somewhat question the utility of this test but I've updated the number rather than contest it.
florianduros
approved these changes
Apr 27, 2026
| "no_args": "No arguments provided. You should supply an emoij and an optional text component.", | ||
| "no_emoji": "You did not provide an emoji", | ||
| "no_text": "You did not provide any status text", | ||
| "too_long_emoji": "The first argument must be an emoji", |
Member
There was a problem hiding this comment.
i18n key meaning seems different than the translation
Member
There was a problem hiding this comment.
Well, it's checking that the emoji is a single grapheme, so the error is that more than one grapheme is "not an emoji" in that it could be multiple emoji, or letters etc. Commented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements:
Status isn't shown anywhere else yet.
Depends on matrix-org/matrix-js-sdk#5246 (merged)
Closes https://github.com/element-hq/wat-internal/issues/465
Checklist
public/exportedsymbols have accurate TSDoc documentation.