Implement call list#5357
Closed
simonwiedmer wants to merge 4 commits into
Closed
Conversation
langleyd
requested changes
Mar 4, 2022
langleyd
left a comment
Member
There was a problem hiding this comment.
Thanks for opening this new feature PR!
The PR needs an issue associated with it describing the feature and also a change log item. Would you mind checking out the contributing guidelines and updating?
Also I think this is a new feature so the issue should be marked X-Needs-Design and X-Needs-Product so that it gets product/design sign-off before inclusion.
Contributor
Author
|
Created corresponding issue #5782 It seems like cannot add tags to the issue. |
Contributor
Author
|
corresponding issue in the SDK: matrix-org/matrix-ios-sdk#1396 |
Contributor
Author
|
Btw, the failing compile check is because it depends on changes in the SDK (matrix-org/matrix-ios-sdk#1307) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This pull-request shows the implementation of the call list on the aarenet specific fork.
It depends on matrix-org/matrix-ios-sdk#1307 for filtering for the PSTN (SIP) call rooms.