all: drop redundant blank lines flagged by the whitespace linter#3696
Open
Deln0r wants to merge 1 commit into
Open
all: drop redundant blank lines flagged by the whitespace linter#3696Deln0r wants to merge 1 commit into
Deln0r wants to merge 1 commit into
Conversation
Six instances of stray blank lines either at the start of a block (right after an opening brace) or at the end of one (right before a closing brace) across appservice, federationapi and roomserver. The whitespace linter flags both shapes; gofmt does not touch them, so they had to be removed by hand. No behavior change. Signed-off-by: Ian Chechin <ian00chechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six instances of stray blank lines either at the start of a block (right after an opening brace) or at the end of one (right before a closing brace), across appservice, federationapi and roomserver. The whitespace linter flags both shapes; gofmt does not touch them, so they had to be removed by hand.
appservice/appservice.go:34{appservice/query/query.go:298{federationapi/routing/invite.go:318}federationapi/routing/join.go:267}federationapi/routing/publicrooms.go:55{roomserver/storage/shared/storage.go:1525}No behavior change.
Test plan
go build ./...clean