Multi gpu ptycho#234
Open
arthurmccray wants to merge 11 commits into
Open
Conversation
…lti GPU compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this PR addressees
Adding multi-gpu support to iterative ptycho. Example notebook here.
I am also making constraints easier to use with a dataclass, tbd if that get's wrapped up in this PR but it doesn't have to.
Also will wait to make this PR properly til we pull dev into diffractive_imaging, as i have done so more recently on my fork.
What should the reviewer(s) do
This isn't a PR into dev so whatever you think is necessary..