fix: fast memory/open file handle bail outs#326
Draft
KillerCodeMonkey wants to merge 3 commits into
Draft
Conversation
Author
|
@MarshallOfSound i know your comment about something like that (#286 (review)). but without some serialization those problems will pop up again and again... even when using queuing.. since we do not know how files/folders are nested it is just a coin throw if it works or not... My issue #325 is related to this and does not occur because of too much files open, but the size the binary check takes (i guess). a folder with a bunch of binary files easily breaks the sign process. And a possible slow sign process (when you really have many files) is better than a not working one when the reason is known. PS: node 16 tests are failing in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please be kind :)
i only hacked it together, since i do not find any tests for the util methods.
it is just an idea.
Another idea: just provide an option to pass a callback that users can override the "walkAsync" method. Providing a "files to sign" method