Skip to content

fix(communities): canonicalize projection order#91

Open
100yenadmin wants to merge 3 commits into
reconcile/r19b-durable-cache-generationfrom
reconcile/r19c-community-order
Open

fix(communities): canonicalize projection order#91
100yenadmin wants to merge 3 commits into
reconcile/r19b-durable-cache-generationfrom
reconcile/r19c-community-order

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Closes #90.

What changed

  • sort eligible community-projection nodes by canonical ID;
  • deduplicate undirected edges using canonical endpoint indices;
  • sort the final edge pairs numerically before Graphology or CSR construction;
  • retain existing confidence, degree, symbol, and large-graph filters.

Proof

  • red-to-green insertion-order regression;
  • community and cohesion suites: 20 passed;
  • repository formatter and git diff --check: passed;
  • GitNexus impact: LOW, one indexed affected cohesion test, exercised.

This removes insertion order as a source of community nondeterminism. It does not waive or mask the separate CALLS and ACCESSES relationship-set mismatch still under disposable canary investigation.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 808a693a-45eb-4a23-8fd2-7d1361aa4af3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r19c-community-order

Comment @coderabbitai help to get the list of available commands.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: stale head

PR: #91 - fix(communities): canonicalize projection order
Head: 369d9939e4d5d8faeeae68efc11af917be568117
Updated: 2026-07-13T20:32:42.935Z

evaOS review stopped because this queued head is no longer the live PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #91

Details: Superseded by a newer PR head.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: stale head

PR: #91 - fix(communities): canonicalize projection order
Head: 5606c4b3eb48977b8190f06047a6954dc1abd08d
Updated: 2026-07-13T20:54:31.335Z

evaOS review stopped because this queued head is no longer the live PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #91

Details: Superseded by a newer PR head.

@100yenadmin

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #91 - fix(communities): canonicalize projection order
Head: 695a3880f71b088a1f4bc2a9d6086e95cd6c940a
Updated: 2026-07-13T21:49:06.795Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #91

Review URL: #91 (review)

@github-actions

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14690 14628 0 62 20s

✅ All 14628 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.89% 54667/67576 N/A% 🟢 ████████████████░░░░
Branches 68.03% 33585/49362 N/A% 🟢 █████████████░░░░░░░
Functions 87.05% 6347/7291 N/A% 🟢 █████████████████░░░
Lines 84.41% 48778/57784 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #91 - fix(communities): canonicalize projection order
Head: 695a3880f71b088a1f4bc2a9d6086e95cd6c940a into reconcile/r19b-durable-cache-generation. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 0. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #90.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

@100yenadmin

Copy link
Copy Markdown
Member Author

Terminal proof for current head 695a3880f71b088a1f4bc2a9d6086e95cd6c940a:

  • CI run 29283779367 completed successfully, including build, typecheck, benchmarks, three-platform tests, coverage merge, packaged install smoke, and CI Gate
  • 14,628 tests passed with zero failures
  • CodeRabbit completed without an actionable finding
  • evaOS review completed for the current head with no validated inline finding
  • current review-thread audit is empty

This supplies the behavior proof that the earlier review walkthrough listed as missing from PR metadata. The PR remains an unmerged capability layer; the combined release candidate is validated separately in PR #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant