Skip to content

fix(cache): bound parsedfile generations#89

Open
100yenadmin wants to merge 1 commit into
reconcile/r21a-cypher-exitfrom
reconcile/r19b-durable-cache-generation
Open

fix(cache): bound parsedfile generations#89
100yenadmin wants to merge 1 commit into
reconcile/r21a-cypher-exitfrom
reconcile/r19b-durable-cache-generation

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Closes #88.

What changed

  • clears and recreates one durable ParsedFile chunk directory before dispatching a cache miss;
  • lets concurrent workers write a single fresh generation without deleting each other;
  • preserves worker directory memoization by recreating the directory before dispatch;
  • bumps PARSE_CACHE_VERSION from schema 12 to 13 so accumulated stores are invalidated once.

Evidence

Disposable public OpenClaw index before the fix contained 41 live chunk hashes, 357 shards, and 4,498 extra byte-identical ParsedFile copies. The new tests cover direct storage replacement and two repeated dispatcher cache misses.

Proof

  • core cache suites: 39 passed;
  • complete indexed affected cluster: 32 passed;
  • repository formatter: passed;
  • git diff --check: passed;
  • GitNexus impact: MEDIUM, 13 indexed callers, all identified test surfaces exercised.

No live index, publication, runtime, or release mutation.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eb07556a-4157-4923-b750-df66fcfc4cea

📥 Commits

Reviewing files that changed from the base of the PR and between f761c9e and 53c6633.

📒 Files selected for processing (4)
  • gitnexus/src/core/ingestion/pipeline-phases/parse-impl.ts
  • gitnexus/src/storage/parse-cache.ts
  • gitnexus/src/storage/parsedfile-store.ts
  • gitnexus/test/unit/parse-impl-warm-cache-parsedfile-coverage.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r19b-durable-cache-generation

Comment @coderabbitai help to get the list of available commands.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #89 - fix(cache): bound parsedfile generations
Head: 53c66332b6130e9fb97524d530a5d18cd9e98c93
Updated: 2026-07-13T21:17:25.194Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #89

Review URL: #89 (review)

@github-actions

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14689 14627 0 62 19s

✅ All 14627 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.89% 54660/67569 N/A% 🟢 ████████████████░░░░
Branches 68.03% 33580/49356 N/A% 🟢 █████████████░░░░░░░
Functions 87.04% 6345/7289 N/A% 🟢 █████████████████░░░
Lines 84.41% 48773/57779 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@100yenadmin

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #89 - fix(cache): bound parsedfile generations
Head: 53c66332b6130e9fb97524d530a5d18cd9e98c93 into reconcile/r21a-cypher-exit. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 0. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #88.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant