Skip to content

fix(vector): report current VECTOR and exact-scan state#80

Open
100yenadmin wants to merge 5 commits into
reconcile/r17-optional-rerankingfrom
reconcile/r18-vector-diagnostics
Open

fix(vector): report current VECTOR and exact-scan state#80
100yenadmin wants to merge 5 commits into
reconcile/r17-optional-rerankingfrom
reconcile/r18-vector-diagnostics

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Closes #57.

Summary

  • live-probe VECTOR loadability in doctor without network installation
  • report the selected path's persisted repository VECTOR state separately from platform support
  • make exact-scan fallback and over-limit refusal visible in core and MCP diagnostics
  • prove a pre-existing HNSW index remains ready after close/reopen on LadybugDB 0.18.0
  • discard superseded and provider-specific historical fork code

Evidence

  • @ladybugdb/core@0.18.0 selected and confirmed
  • 8 real LadybugDB VECTOR integration tests passed
  • 323 focused embedding, exact-scan, doctor, MCP, and analyze tests passed
  • typecheck and build passed
  • built gitnexus doctor . smoke passed
  • targeted lint completed with 0 errors
  • no live index, runtime, package, release, or publication mutation

Retained evidence:
/Volumes/LEXAR/Codex/session-notes/2026-07-13/gitnexus-fork-upstream-reconciliation/r18-vector-diagnostics.md

Historical Disposition

Historical commits b376062f and 8cacdab3 were audited but not cherry-picked. Raw-query creation, idempotent existing-index handling, exact-scan fallback, and per-repo metadata are already present. The old premium-provider guard remains discarded; this PR carries only the current generic diagnostic gaps.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8d82865a-ca14-4f86-b0d0-a2a94d6a7990

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r18-vector-diagnostics

Comment @coderabbitai help to get the list of available commands.

@100yenadmin 100yenadmin changed the title R18: report current VECTOR and exact-scan state fix(vector): report current VECTOR and exact-scan state Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

✨ PR Autofix

Found fixable formatting / unused-import issues across 229 changed lines. Comment /autofix on this PR to apply them, or run npm run lint:fix && npm run format locally.

{"schema":"gitnexus.pr-autofix/v2","state":"fixes-available","pr_number":80,"changed_lines":229,"head_sha":"0c0a30ec1cab494a138e99f6df7c8366ad1cbbe1","run_id":"29278248248","apply_command":"/autofix"}

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #80 - fix(vector): report current VECTOR and exact-scan state
Head: ff868de30bb715614d86f3171b5d13533d0f6c91
Updated: 2026-07-13T13:58:39.699Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #80

Review URL: #80 (review)

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14684 14622 0 62 15s

✅ All 14622 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.88% 54644/67560 N/A% 🟢 ████████████████░░░░
Branches 68.01% 33564/49345 N/A% 🟢 █████████████░░░░░░░
Functions 87.03% 6343/7288 N/A% 🟢 █████████████████░░░
Lines 84.39% 48757/57770 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #80 - fix(vector): report current VECTOR and exact-scan state
Head: ff868de30bb715614d86f3171b5d13533d0f6c91 into reconcile/r17-optional-reranking. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 0. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #57.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: stale head

PR: #80 - fix(vector): report current VECTOR and exact-scan state
Head: 0c0a30ec1cab494a138e99f6df7c8366ad1cbbe1
Updated: 2026-07-13T19:31:30.902Z

evaOS review stopped because this queued head is no longer the live PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #80

Details: Superseded by a newer PR head.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #80 - fix(vector): report current VECTOR and exact-scan state
Head: 0309490867b875aef65ddf6eb6c0c7ef10e158eb
Updated: 2026-07-13T20:53:27.124Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #80

Review URL: #80 (review)

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #80 - fix(vector): report current VECTOR and exact-scan state
Head: 0309490867b875aef65ddf6eb6c0c7ef10e158eb into reconcile/r17-optional-reranking. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 3. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #57.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant