Skip to content

feat(embeddings): add resilient resumable HTTP pipeline#78

Open
100yenadmin wants to merge 2 commits into
reconcile/r15-mcp-repository-policyfrom
reconcile/r16-embedding-http-resilience
Open

feat(embeddings): add resilient resumable HTTP pipeline#78
100yenadmin wants to merge 2 commits into
reconcile/r15-mcp-repository-policyfrom
reconcile/r16-embedding-http-resilience

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Capability

Implements R16: provider-neutral, bounded, cancellable, and resumable HTTP embedding.

  • Adds validated max-attempt, retry-cap, and minimum-interval configuration.
  • Honors capped Retry-After and paces every attempt through one queue.
  • Threads cancellation through fetch waits, pipeline boundaries, and server jobs.
  • Adds awaited LadybugDB checkpoints plus sanitized analyze metadata markers.
  • Resumes from persisted content hashes and rejects model/dimension drift before mutation.
  • Redacts credentials from both visible errors and nested diagnostic causes.
  • Documents the operator controls without embedding provider-specific policy.

This reconstructs the generic portions of legacy commits bddb62c7, 0851e77d, ee47090e, and c478f4a4; none is cherry-picked.

Evidence

  • Focused resilience/resume matrix: 173 passed.
  • Broader embedding/server regression matrix: 85 passed.
  • Disposable LadybugDB checkpoint/resume and identity-mismatch cases: passed.
  • TypeScript and full package build: passed.
  • Targeted ESLint: zero errors; existing warnings only.
  • Diff check and original-worktree integrity hashes: passed.
  • Detailed evidence: /Volumes/LEXAR/Codex/session-notes/2026-07-13/gitnexus-fork-upstream-reconciliation/r16-embedding-http-resilience.md.

Stack And Gate

  • Base: reconcile/r15-mcp-repository-policy at 1d55fec52397cefc2c4ac9c881bfd4da2b5299e7.
  • Head: 8970429dea73bd35283f7eea8046cd3594010f64.
  • This PR must wait for R15, then be retargeted to the integration branch and revalidated at current head.
  • R17 keeps optional reranking isolated behind a separate provider interface.
  • Publication, runtime rollout, live-index mutation, and default-branch promotion are outside this PR.

Closes #55 after merge.
Parent epic: #39.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6972144b-2130-4748-adc8-6bb8b6b47cc6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r16-embedding-http-resilience

Comment @coderabbitai help to get the list of available commands.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #78 - feat(embeddings): add resilient resumable HTTP pipeline
Head: 8970429dea73bd35283f7eea8046cd3594010f64
Updated: 2026-07-13T13:38:21.209Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #78

Review URL: #78 (review)

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #78 - feat(embeddings): add resilient resumable HTTP pipeline
Head: 8970429dea73bd35283f7eea8046cd3594010f64 into reconcile/r15-mcp-repository-policy. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 2. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #55, #39.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14653 14591 0 62 14s

✅ All 14591 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.85% 54473/67373 N/A% 🟢 ████████████████░░░░
Branches 67.98% 33416/49154 N/A% 🟢 █████████████░░░░░░░
Functions 86.98% 6318/7263 N/A% 🟢 █████████████████░░░
Lines 84.37% 48597/57599 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #78 - feat(embeddings): add resilient resumable HTTP pipeline
Head: f32f14ecd3c7ab151efb5a88510ba332c3381af0
Updated: 2026-07-13T19:30:26.444Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #78

Review URL: #78 (review)

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #78 - feat(embeddings): add resilient resumable HTTP pipeline
Head: f32f14ecd3c7ab151efb5a88510ba332c3381af0 into reconcile/r15-mcp-repository-policy. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 2. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #55, #39.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant