[W5b] #1433 Player build: fix magenta occluder shader + wire CombatSurfaceClient live

[100yenadmin]

Closes the two gaps between the running WorldOSPlayer.app (#1322 / PR #1432) and the T3 gate. Box work on GEX44 (claim → release on #1322).

1) Magenta blocks = stripped runtime occluder shader

• The Occluder_* depth-proxy cubes in M1CombatV1_canonical.unity used WorldOS/OccluderDepth, created AT RUNTIME by paint_combat_v1.cs via ShaderUtil.CreateShaderAsset and serialized inline → not compiled into a standalone player build → pink error shader = magenta (fine in-editor, only breaks the player). Pipeline is built-in RP (Standard/Unlit/* were never the issue).
• Fix (byte-identical editor color): commit Assets/OccluderDepth.shader (source byte-for-byte the runtime string — ColorMask 0, depth-only); reassign the scene's occluder material to the committed asset (now m_Shader guid: 8c8c25e6…, type: 3); add it to Always-Included Shaders; paint_combat_v1 now prefers Shader.Find (runtime fallback keeps captures byte-identical).
• Build log proves inclusion: Importing … Assets/OccluderDepth.shader (ShaderImporter) + Compiling shader "WorldOS/OccluderDepth" + Serialized binary data. Build Succeeded, 0 errors, Universal (x64ARM64), 158.4 MB. (qa/evidence/1433/.)

2) CombatSurfaceClient wired live

• Attached to M1CombatV1_canonical (was unattached, W5a-flagged). Runtime-only → editor captures unaffected.
• Actor resolution: GameObject.Find("Actor_" + token.id) (current Actor_char_<hash> registry naming) — replaces the stale HeroFighter/MonsterGoblin lookups.
• Cell↔world mirrors paint_combat_v1 exactly (grid from surface, cell 2.0, row-flip) — was the stale 14×10/cell-5 math. Bounds-centered on the cell → no jump on first poll; _AO/_Core/_Ring follow.
• Input: click → floor raycast → cell → POST /move, existing kinds only (move_to_cell / on-turn attack), payloads byte-exact to qa/drive_gfx_combat.py. Pure consumer; engine = sole writer. Reads WORLDOS_ENGINE_BASE_URL/WORLDOS_CAMPAIGN_ID (feat(macos): W5 player-build launch handoff (#1322) #1430).

Guard rails

Additive. paint_combat_v1 capture flow preserved (shader fallback + runtime-only client). W5bWireScene is an #if UNITY_EDITOR migration MenuItem (excluded from the player assembly).

Delivery / T3

Rebuilt .app scp'd to the Mac at ~/worldos-session-notes/w5a-build/WorldOSPlayer.app.zip (overwrite). T3 gate run is NOT this lane — the orchestrator smoke-tests the built player locally first (macOS build can't run on the Linux box). Remaining for T3: live-loop smoke against a running engine (verify no magenta + click-to-move round-trips), and that combat foe tokens have a matching Actor_* in the static scene (runtime spawn is a separate future item — the player build can only reposition pre-placed actors).

Refs #1322, PR #1430, PR #1432. Admin-merge per #1389 when CI is green.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e1e3933c-860c-4615-a555-9092e61aeedb

📥 Commits

Reviewing files that changed from the base of the PR and between 8475c59 and 1df027c.

⛔ Files ignored due to path filters (2)

• extensions/renderers/unity/shaders/OccluderDepth.shader is excluded by !**/*.shader
• qa/evidence/1433/before_first_mac_player_launch_magenta.png is excluded by !**/*.png

📒 Files selected for processing (6)

• extensions/renderers/unity/scripts/CombatSurfaceClient.cs
• extensions/renderers/unity/scripts/W5bWireScene.cs
• extensions/renderers/unity/scripts/paint_combat_v1.cs
• qa/evidence/1433/NOTES.md
• qa/evidence/1433/build-report.txt
• qa/evidence/1433/shader-inclusion.txt

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/1433-w5b-wiring

---

_{Comment @coderabbitai help to get the list of available commands.}