lib,mod: handle map[any]any and []any from cel-go v0.27.0#122
Merged
Conversation
cel-go v0.27.0 (cel-expr/cel-go#1261) changed ConvertToNative to remap interface{} targets to map[any]any for maps and []any for lists. This breaks type switches in makeMapStrings, makeStrings, and mapStrings that expected the previous map[ref.Val]ref.Val and []ref.Val types. Add cases for the new types, round-tripping through NativeToValue and ConvertToNative with an explicit target type. Retract v1.25.0 which shipped without this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cel-go v0.27.0 (cel-expr/cel-go#1261) changed ConvertToNative to remap interface{} targets to map[any]any for maps and []any for lists. This breaks type switches in makeMapStrings, makeStrings, and mapStrings that expected the previous map[ref.Val]ref.Val and []ref.Val types.
Add cases for the new types, round-tripping through NativeToValue and ConvertToNative with an explicit target type.
Retract v1.25.0 which shipped without this fix.
This will be tagged as v1.25.1, tested against filebeat cel input tests.