[9.3] [ftr] skip FTR tests when changes are scoped to "test/scout/**" (#280853)#280880
Open
kibanamachine wants to merge 1 commit into
Open
[9.3] [ftr] skip FTR tests when changes are scoped to "test/scout/**" (#280853)#280880kibanamachine wants to merge 1 commit into
kibanamachine wants to merge 1 commit into
Conversation
…tic#280853) ## Summary Fixing the issue I found in [CI run](https://buildkite.com/elastic/kibana-pull-request/builds/475407): changes limited to `discover/test/scout/**` (Scout tests) were still triggering full FTR runs, because: - Any file under a plugin's `test/scout/**` folder is attributed to that plugin's module (e.g. `@kbn/discover-plugin`), so the FTR skip logic saw a "real" module and refused to skip. - The Scout-tests-only fast path excludes `fixtures/` files (treating them as regular changes), which also blocked the skip when fixtures were touched. ### Fix - `selective_ftr.ts`: `shouldSkipFtrTests` now skips FTR whenever every changed file matches an irrelevant path (including `**/test/scout{_*,}/**`), regardless of which module owns the directory. - `selective_scout.ts` / `pick_test_group_run_order.ts`: added `isScoutPathOnlyDiff`, used for the Jest/FTR fast path. It's like `isScoutTestsOnlyDiff` but doesn't `exclude fixtures/`, since Jest/FTR can never consume Scout fixtures anyway — the fixtures distinction only matters for Scout's own test selection. ### Testing Added unit tests in `selective_ftr.test.ts` and `selective_scout.test.ts` covering Scout-only diffs (with and without fixtures). (cherry picked from commit 34b4759)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
Historycc @dmlemeshko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation