[9.4] [Agent Builder] Prevent conversation overwrite via auto-create (#280189)#280877
Open
brunofarache wants to merge 2 commits into
Open
[9.4] [Agent Builder] Prevent conversation overwrite via auto-create (#280189)#280877brunofarache wants to merge 2 commits into
brunofarache wants to merge 2 commits into
Conversation
…ic#280189) Manual backport of elastic#280189 adapted to the 9.4 hasAccess-based conversation client. Makes exists() report physical document existence and create() non-destructive via op_type: 'create'.
brunofarache
marked this pull request as ready for review
July 24, 2026 19:20
brunofarache
enabled auto-merge (squash)
July 24, 2026 19:22
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:This is a manual backport of #280189. The 9.4 conversation client still uses the older
hasAccess-based shape, so the fix was adapted by hand rather than cherry-picked cleanly. Only the conversation client (client.ts) and its unit test (client.test.ts) are changed:exists()now reports physical document existence and no longer applies the access gate.create()usesop_type: 'create'so an existing conversation (e.g. owned by another user) is never overwritten.Security fix. Please review carefully before merging.
Questions ?
Please refer to the Backport tool documentation