[Entity Store] Drop Okta name fragments from related.user alias resolution#280868
Draft
maxcold wants to merge 1 commit into
Draft
[Entity Store] Drop Okta name fragments from related.user alias resolution#280868maxcold wants to merge 1 commit into
maxcold wants to merge 1 commit into
Conversation
…ution Prevent false alias links from Okta first/last/middle/nick name values appended into related.user while keeping display-name bridging.
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #278418.
The
related_user_alias_resolutionbridge rule reads a seed'srelated.userlist and links entities whose identity fields match those values. Okta's ingest pipeline appends personal name fragments (first_name,last_name,middle_name,nick_name) intorelated.user, which are far more collision-prone than stable identifiers and can create false alias links between unrelated people who share a common name.This change extends the existing Okta exclusion path (already used for manager fields) so those name-fragment source values are dropped before candidate lookup. Display name is intentionally kept for display-name bridging.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
user.id, login, email) and display name remain; the rule is still OFF by default. Severity: low — preferred over false-positive links across unrelated people.