[As Code] Stringify zod panel warnings on dropped panels from dashboards#280806
Draft
nickpeihl wants to merge 101 commits into
Draft
[As Code] Stringify zod panel warnings on dropped panels from dashboards#280806nickpeihl wants to merge 101 commits into
nickpeihl wants to merge 101 commits into
Conversation
When porting from @kbn/config-schema to Zod, the old config-schema
convention of `{ meta: { description: '...' } }` was carried over
verbatim. Zod's .meta() takes a flat object, so the extra `meta:` layer
was passed through z.toJSONSchema() as-is and emitted into OAS output
as an invalid `meta:` property, triggering additionalProperties errors.
Claude-Session: https://claude.ai/code/session_0192CGTMjJU7B5T5FRGEykcr
Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
Converts allowHiddenIndicesSchema from @kbn/config-schema (unimported) to z.boolean().optional().meta(), fixing a ReferenceError on startup that caused all discover/as-code jobs to fail. Claude-Session: https://claude.ai/code/session_0132ugcMCNCJZSqUGDsh8pPM
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after #268329
Summary
Stringify zod panel warnings on dropped panels from dashboards
Zod validation errors on panel transforms are returned as JSON objects which doesn't translate well in the warnings panel in the dashboard or in the warning array from the API endpoints. Fortunately, we have a zod helper to make the errors more pretty.
Note: The
stringifyZodErrorhelper also limits the number of reported errors to five and reports a count of the remaining errors.Examples
Before:
After:
Before:
After: