Crawl connectors, which finds all recently updated connector instances#280592
Crawl connectors, which finds all recently updated connector instances#280592erikcurrin-elastic wants to merge 5 commits into
Conversation
…s and recreate the SML record for them
| const soRepository = savedObjects.createInternalRepository(); | ||
|
|
||
| // connectors are hidden, so we need action here to expose them during crawl | ||
| const soRepository = savedObjects.createInternalRepository(['action']); |
There was a problem hiding this comment.
This task runner is shared by all attachment types, so every crawl will depend on the hidden action type being registered.Do we want this type of access for non-connector crawls? Should they be scoped to only connector crawls?
Can we please add some tests that handle when action mappings are not preasent?
There was a problem hiding this comment.
Fiddled with this, we can have the definition have an array for this (hiddenTypes I guess?). Then connectors is the only thing that sets it.
There was a problem hiding this comment.
Reviewed the connector SML crawler change. The list crawler, the requiredHiddenTypes plumbing into createInternalRepository, and the added test coverage are sound and consistent with the crawler security model. One inline note on a now-stale doc comment.
Generated by Claude Reviewer for #280592 · 19.9 AIC · ⌖ 0.815 AIC
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
Summary
Implement a crawler for connectors that recreates the SML entries for them
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.