Remove orphan top-level integrations gitlink - #267940
Merged
nickofthyme merged 2 commits intoMay 6, 2026
Merged
Conversation
elastic#243732 ([Lens] Improve transform validation checking) accidentally recorded a top-level `integrations` submodule pointer (mode 160000, sha 5a5d30c6ebf4fef2c4226a67c31d772ceb93230d) without an entry in .gitmodules (which doesn't exist in this repo). The intent was to add files under src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/ — that part of the change is preserved; only the stray top-level gitlink is removed. The stray gitlink causes actions/checkout's post-job cleanup (`git submodule foreach --recursive`) to abort with exit 128: fatal: No url found for submodule path 'integrations' in .gitmodules This marks the docs CI jobs (`build / build`, `build / vale`) red on every PR touching `docs/**`, even when docs-builder reports 0 Errors / 0 Warnings / 0 Hints. First seen on elastic#267647. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nickofthyme
approved these changes
May 6, 2026
Contributor
|
Thanks @theletterf I forgot to check this. We just pull down the repo to capture the panel data locally, but this is not something that is needed in kibana. Sorry for the trouble. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @theletterf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#243732 ([Lens] Improve transform validation checking) accidentally recorded a top-level
integrationssubmodule pointer (mode 160000, sha5a5d30c6ebf4fef2c4226a67c31d772ceb93230d) without an entry in.gitmodules(which doesn't exist in this repo). The intent was to add files undersrc/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/— that part of the change is preserved; only the stray top-level gitlink is removed.The orphan gitlink causes
actions/checkout's post-job cleanup (git submodule foreach --recursive) to abort with exit 128:This marks the docs CI jobs (
build / build,build / vale) red on every PR that touchesdocs/**, even when docs-builder itself reports0 Errors / 0 Warnings / 0 Hints. First seen on #267647.cc @nickofthyme — most likely a
git submodule add/.gitmodulesinteraction during local work on #243732. Please confirm nothing in the Lens integration tests actually needs a populated submodule at the repo root (the per-packagetests/integrations/directory is untouched here).A complementary defensive fix is up at elastic/docs-actions#139 so future orphan gitlinks degrade to a CI warning instead of a hard failure.
Checklist
release_note:skip.mainonly (the bad commit hasn't been backported).Identify risks
git rm --cached integrationsonly. No working-tree files are removed. The Lens integration test files added in [Lens] Improve transform validation checking #243732 (undersrc/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/) are untouched.Test plan
src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/is unchanged.mode 160000entries remain at the repo root:git ls-files --stage | awk '$1 == "160000"'returns empty.build / buildandbuild / valego green on a docs PR (e.g. [Docs]: Add Fleet setting for setting the task interval for version-specific policy assignment #267647) without any other change.🤖 Generated with Claude Code