Skip to content

Remove orphan top-level integrations gitlink - #267940

Merged
nickofthyme merged 2 commits into
elastic:mainfrom
theletterf:fab/remove-orphan-integrations-gitlink
May 6, 2026
Merged

Remove orphan top-level integrations gitlink#267940
nickofthyme merged 2 commits into
elastic:mainfrom
theletterf:fab/remove-orphan-integrations-gitlink

Conversation

@theletterf

Copy link
Copy Markdown
Member

Summary

#243732 ([Lens] Improve transform validation checking) accidentally recorded a top-level integrations submodule pointer (mode 160000, sha 5a5d30c6ebf4fef2c4226a67c31d772ceb93230d) without an entry in .gitmodules (which doesn't exist in this repo). The intent was to add files under src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/ — that part of the change is preserved; only the stray top-level gitlink is removed.

The orphan gitlink causes actions/checkout's post-job cleanup (git submodule foreach --recursive) to abort with exit 128:

fatal: No url found for submodule path 'integrations' in .gitmodules

This marks the docs CI jobs (build / build, build / vale) red on every PR that touches docs/**, even when docs-builder itself reports 0 Errors / 0 Warnings / 0 Hints. First seen on #267647.

cc @nickofthyme — most likely a git submodule add / .gitmodules interaction during local work on #243732. Please confirm nothing in the Lens integration tests actually needs a populated submodule at the repo root (the per-package tests/integrations/ directory is untouched here).

A complementary defensive fix is up at elastic/docs-actions#139 so future orphan gitlinks degrade to a CI warning instead of a hard failure.

Checklist

  • No user-facing changes — release_note:skip.
  • No backport needed — affects main only (the bad commit hasn't been backported).

Identify risks

  • None. The change is git rm --cached integrations only. No working-tree files are removed. The Lens integration test files added in [Lens] Improve transform validation checking #243732 (under src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/) are untouched.

Test plan

🤖 Generated with Claude Code

elastic#243732 ([Lens] Improve transform validation checking) accidentally
recorded a top-level `integrations` submodule pointer (mode 160000,
sha 5a5d30c6ebf4fef2c4226a67c31d772ceb93230d) without an entry in
.gitmodules (which doesn't exist in this repo). The intent was to
add files under
src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/tests/integrations/
— that part of the change is preserved; only the stray top-level
gitlink is removed.

The stray gitlink causes actions/checkout's post-job cleanup
(`git submodule foreach --recursive`) to abort with exit 128:

    fatal: No url found for submodule path 'integrations' in .gitmodules

This marks the docs CI jobs (`build / build`, `build / vale`) red on
every PR touching `docs/**`, even when docs-builder reports
0 Errors / 0 Warnings / 0 Hints. First seen on elastic#267647.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@theletterf theletterf self-assigned this May 6, 2026
@theletterf theletterf added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels May 6, 2026
@nickofthyme

nickofthyme commented May 6, 2026

Copy link
Copy Markdown
Contributor

Thanks @theletterf I forgot to check this. We just pull down the repo to capture the panel data locally, but this is not something that is needed in kibana. Sorry for the trouble.

@kibanamachine

Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #18 / task_manager migrations 8.5.0 migrates active tasks to set enabled to true

Metrics [docs]

✅ unchanged

History

cc @theletterf

@nickofthyme
nickofthyme merged commit 1c7e7dd into elastic:main May 6, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants