[ES|QL] Fix VerificationException when in subquery is used together with QSTR/KQL#155010
Draft
fang-xing-esql wants to merge 2 commits into
Draft
[ES|QL] Fix VerificationException when in subquery is used together with QSTR/KQL#155010fang-xing-esql wants to merge 2 commits into
VerificationException when in subquery is used together with QSTR/KQL#155010fang-xing-esql wants to merge 2 commits into
Conversation
Collaborator
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #154758
Fixes two bugs that caused
QSTR/KQLcombined with(NOT) IN subqueriesto fail with aVerificationException.Bug 1 —
FullTextFunction.checkCommandsBeforeExpression used plan.forEachDownto walk the logical plan, which descended into the RHS of anAbstractSubqueryJoin, it should only look into the LHS of anAbstractSubqueryJoin, as the RHS is a non-correlated query, and it should not affect the FTF in its parent query. Also the synthetic attributes created byMarkJoinshould not blockQSTR/KQL.Bug 2 —
PushDownAndCombineFiltersdidn't push filter pastAbstractSubqueryJoin.A new
WHERE_IN_SUBQUERY_WITH_QSTR_KQL_FIXcapability gates all new CSV-spec tests, which cover theAND/OR×IN/NOT IN×QSTR/KQLmatrix including the hash-join execution path with multi-valued fields.