Skip to content

Fix ShardRoutingTests#testEqualsIgnoringVersion#155005

Merged
nicktindall merged 2 commits into
elastic:mainfrom
nicktindall:fix_ShardRoutingTests
Jul 25, 2026
Merged

Fix ShardRoutingTests#testEqualsIgnoringVersion#155005
nicktindall merged 2 commits into
elastic:mainfrom
nicktindall:fix_ShardRoutingTests

Conversation

@nicktindall

@nicktindall nicktindall commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Just

  • a missing randomValueOtherThan which sometimes left recovery priority unchanged when mutating the object
  • a missing builder method invocation which sometimes reset the recovery priority

Fixes #154886

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.6.0 labels Jul 24, 2026
@nicktindall
nicktindall marked this pull request as draft July 24, 2026 22:55
@nicktindall nicktindall added >test Issues or PRs that are addressing/adding tests :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. labels Jul 24, 2026
@nicktindall
nicktindall marked this pull request as ready for review July 24, 2026 23:24
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team. and removed needs:triage Requires assignment of a team area label labels Jul 24, 2026
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@bcully bcully left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktindall
nicktindall merged commit 608b7b6 into elastic:main Jul 25, 2026
37 checks passed
@nicktindall
nicktindall deleted the fix_ShardRoutingTests branch July 25, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ShardRoutingTests testEqualsIgnoringVersion failing

3 participants