Use correct recovery priority for unassigned shards#154974
Draft
PeteGillinElastic wants to merge 1 commit into
Draft
Use correct recovery priority for unassigned shards#154974PeteGillinElastic wants to merge 1 commit into
PeteGillinElastic wants to merge 1 commit into
Conversation
PeteGillinElastic
added
>non-issue
:Distributed/Recovery
This changes `ShardRouting.newUnassigned()` to use a `RecoveryPriority` derived from the `UnassignedInfo.Reason`, which should be the correct choice between `UNASSIGNED_EXISTING` and `UNASSIGNED_NEW`, rather than always using `UNASSIGNED_EXISTING`. The validation on `ShardRouting` is strengthened to ensure that the `RecoveryPriority` is always consistent with the `UnassignedInfo`. Relates elastic/elasticsearch-team#2918
PeteGillinElastic
force-pushed
the
dnrt-recovery-priority-correct-values
branch
from
July 24, 2026 15:36
31f4cab to
07068e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
ShardRouting.newUnassigned()to use aRecoveryPriorityderived from theUnassignedInfo.Reason, which should be the correct choice betweenUNASSIGNED_EXISTINGandUNASSIGNED_NEW, rather than always usingUNASSIGNED_EXISTING.The validation on
ShardRoutingis strengthened to ensure that theRecoveryPriorityis always consistent with theUnassignedInfo.Relates elastic/elasticsearch-team#2918