Skip to content

Addressing inference timeout issues on inference operator tests #154972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmpailis wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −1
Open

Addressing inference timeout issues on inference operator tests #154972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
970c0ad
iter
pmpailis Jul 24, 2026
28c7d6a
iter
pmpailis Jul 24, 2026
79eadce
Update docs/changelog/154972.yaml
pmpailis Jul 24, 2026
7f66169
Merge branch 'main' into fix_154866_addressing_inference_timeout_issu…
pmpailis Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/154972.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
area: ES|QL
issues:
- 154866
pr: 154972
summary: Addressing inference timeout issues on inference operator tests
type: bug
5 changes: 4 additions & 1 deletion ...k/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/inference/InferenceOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,10 @@ public BulkInferenceRequestItem pollNextRequest() {
}

synchronized (checkpoint) {
if (requestItemIterator.hasNext() == false) {
// Re-check under the lock: completeIfFinished() releases the request iterator (and its backing block) while holding
// this lock when a failure occurs. Without re-checking, a concurrent poller that passed the guard above could invoke
// requestItemIterator.next() on an already-released block. See https://github.com/elastic/elasticsearch/issues/154866

@mayya-sharipova mayya-sharipova Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudl we remove mention of the issue here: "#154866" and keep comment general overall.

if (hasFailure() || completed.get() || requestItemIterator.hasNext() == false) {
return null;
}

Expand Down
Loading