Introduce EngineBatch abstraction#154917
Open
Tim-Brooks wants to merge 7 commits into
Open
Conversation
Replaces the two-argument indexBatch(List<Index>, SourceBatch) on Engine and IndexShard with a single EngineBatch record. No behavior change — callers and overrides are updated mechanically. This unblocks swapping the internal batch representation in a follow-on PR.
Tim-Brooks
added
>non-issue
:Distributed/CRUD
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
This is a first step to pare down this follow-up PR just a bit: #154782. |
Contributor
|
The test failures here that show up in the Flakiness Summary are due to #149623, at least by my read (and don't need to be addressed as part of this PR). |
joegallo
reviewed
Jul 24, 2026
joegallo
left a comment
joegallo
left a comment
Contributor
There was a problem hiding this comment.
Ah, nice, it's going to be great to have the batch and operations merged together. 🚀
joegallo
approved these changes
Jul 24, 2026
Contributor
|
I merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the two-argument indexBatch(List, SourceBatch) on
Engine and IndexShard with a single EngineBatch record. No behavior
change — callers and overrides are updated mechanically. This
unblocks swapping the internal batch representation in a follow-on PR.