Skip to content

Codegen name for _slice#6500

Merged
l-trotta merged 1 commit into
mainfrom
codegen-name-new-slice
Jul 20, 2026
Merged

Codegen name for _slice#6500
l-trotta merged 1 commit into
mainfrom
codegen-name-new-slice

Conversation

@l-trotta

Copy link
Copy Markdown
Contributor

Followup of #6427. The new _slice parameter clashes with the old slice in 3 classes (SearchRequest, DeleteByQueryRequest, UpdateByQueryRequest) because some of the language clients remove underscores, or convert snake case to camel case. Adding a @codegen_name annotation to rename it to route_slice in all its occurrences.

@MattDevy MattDevy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta closed this Jul 20, 2026
@l-trotta l-trotta reopened this Jul 20, 2026
@l-trotta
l-trotta merged commit a915ba7 into main Jul 20, 2026
22 checks passed
@l-trotta
l-trotta deleted the codegen-name-new-slice branch July 20, 2026 15:07
l-trotta added a commit that referenced this pull request Jul 20, 2026
(cherry picked from commit a915ba7)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants