fix(indices): add max_retention to RetentionSource enum#6333
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(indices): add max_retention to RetentionSource enum#6333github-actions[bot] wants to merge 1 commit into
max_retention to RetentionSource enum#6333github-actions[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6330
Adds the missing
max_retentionvalue to theRetentionSourceenum inspecification/indices/_types/DataStreamLifecycle.ts.Elasticsearch returns
"max_retention"as a validretention_determined_byvalue when the data stream's effective retention is capped by the globalmax_retentionsetting (GlobalRetention.max_retention). Without this value in the enum, Kibana's TypeScript type check fails when comparing or assigning"max_retention"toRetentionSource.