security: harden docs-builder, changelog, and workflow trust boundaries - #159
Open
cotti wants to merge 4 commits into
Open
security: harden docs-builder, changelog, and workflow trust boundaries#159cotti wants to merge 4 commits into
cotti wants to merge 4 commits into
Conversation
3 tasks
theletterf
previously requested changes
May 17, 2026
Member
|
The SHA pins for Since this PR landed, both actions were moved in-house into this repo:
The original security concern was a floating Suggest removing the SHA pins from this PR (or following up with a cleanup PR if it has already landed) to reduce maintenance overhead. |
cotti
force-pushed
the
fix/hardening-batch
branch
from
July 13, 2026 23:34
a428d32 to
87573c5
Compare
theletterf
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilt on the current
mainto retain only the security remediations that arestill needed. The obsolete Vale SHA-pin changes and unrelated generated
workflow/compiler churn have been removed.
Issues addressed
docs-deploy.ymland thedocs-builder/setupedge path pullghcr.io/elastic/docs-builder:edge, resolve it to an immutableRepoDigest, and use that digest for the rest of the job.0600files underRUNNER_TEMP, capped at 64 KiB without splitting UTF-8 code points. The validate path reads directly fromGITHUB_EVENT_PATH; neither path transports the body through a step output or environment variable. Inline title metadata is bounded/sanitized and comma-containing label names fail closed.workflow_run.actor, and (when present)workflow_run.triggering_actorall to be Elastic members. Commit authors/committers are intentionally excluded because they represent authorship rather than the account that pushed and triggered the run.Resolved elsewhere / removed from this PR
#509: removed. Vale was
migrated into this repository by
docs-actions#162, and the
reusable workflows now call
elastic/docs-actions/vale/{lint,report}@v1.Separately pinning an action inside the same repository would not add a useful
trust boundary.
Dependencies and follow-ups
elastic/docs-builder#3329.
That PR adds the
PR_BODY_FILEsupport consumed by the #505 remediation.verification remains in
docs-actions#160 and depends
on docs-builder publishing an attested edge image.
Commits
c55ade1security: pin docs-builder edge image per run41a6378security: stage changelog PR bodies in files07715f0security: harden changelog PR comment rendering87573c5security: verify workflow-run actors for fork trust gatesVerification
pre-commit run --all-filesoutput omission, and comma-label rejection
explicit-user compatibility, and absent-token fail-closed
node --checkfor all modified/new JavaScript filesgit diff --check origin/main...HEAD