support custom markers with values#194
Open
AndrewChubatiuk wants to merge 1 commit into
Open
Conversation
|
💚 CLA has been signed |
AndrewChubatiuk
force-pushed
the
support-custom-markers-with-values
branch
from
d7a1ac2 to
2066862
Compare
Author
|
hey @thbkrkr |
AndrewChubatiuk
force-pushed
the
support-custom-markers-with-values
branch
from
2066862 to
c85b7b3
Compare
AndrewChubatiuk
force-pushed
the
support-custom-markers-with-values
branch
from
f677845 to
9ab7749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently only custom markers without values are supported, this PR adds ability to use
hasValueparameter to treat given custom marker as marker with valuerelated issue #124