x-pack/filebeat/input/cel: integrate emit macro and stream producers#51279
x-pack/filebeat/input/cel: integrate emit macro and stream producers#51279efd6 wants to merge 1 commit into
Conversation
🤖 GitHub commentsJust comment with:
|
🔍 Preview links for changed docs |
Elastic Docs Style Checker (Vale)Summary: 1 warning, 2 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| docs/reference/filebeat/filebeat-input-cel.md | 125 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
💡 Suggestions (2): Optional style improvements. Apply when helpful.
| File | Line | Rule | Message |
|---|---|---|---|
| docs/reference/filebeat/filebeat-input-cel.md | 125 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| docs/reference/filebeat/filebeat-input-cel.md | 165 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
a5dbfff to
dcf2c4d
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughThe PR bumps 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/filebeat/filebeat-input-cel.md`:
- Line 125: Fix three linting issues in the events field description: First,
remove the duplicate "will" in the phrase "this will will be wrapped" so it
reads "this will be wrapped". Second, review the punctuation placement around
the quoted text to ensure punctuation marks are placed inside the quotation
marks where appropriate. Third, verify the markdown link fragment for the emit
macro reference uses correct syntax and formatting to resolve the MD051 link
validation error. These fixes will ensure the documentation passes Vale,
Markdownlint, and CI validation checks.
- Line 149: The fenced code block containing the emit method examples lacks a
language identifier specification. Locate the code block that contains the
comments about two-arg and three-arg publish patterns with the emit method
calls, and add the language identifier "cel" to the opening fence by changing
the opening triple backticks from ``` to ```cel to comply with markdownlint-cli2
validation requirements.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: a5f2d64d-740f-4215-a397-48297ab079a1
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (7)
NOTICE.txtchangelog/fragments/1781587054-cel-emit-stream.yamldocs/reference/filebeat/filebeat-input-cel.mdgo.modx-pack/filebeat/input/cel/config.gox-pack/filebeat/input/cel/input.gox-pack/filebeat/input/cel/input_test.go
…d lazy decoders Wire up the emit macro, stream producers (stream_gzip, stream_zip), lazy JSON stream decoders (decode_json_stream_lazy), lazy CSV stream decoders (decode_csv_stream_lazy, decode_csv_stream_lazy_no_header), and line streaming (decode_lines) from the updated mito library into the CEL input. Add tests for the new streaming and emit functionality and update the CEL input documentation with the new extension library entries. Assisted-By: Cursor
Proposed commit message
Note
This is the partner to elastic/mito#130. That change has the implementation for
emitand the streaming calls.Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
How to test this PR locally
Related issues
Use cases
Screenshots
Logs