Localize ask decision UI#2
Open
jerryfan wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR. I'll dive into it tomorrow, cause I was working on the same thing in parallel, so I'll have to check how it can be "synced" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found one small UX issue: ask_user is a decision point where users choose answers, add notes, elaborate, submit, or cancel. If those labels are misread, the agent can continue with the wrong direction.
This PR makes that decision surface optionally localizable while preserving the current English strings as fallbacks.
Validation:
Note: npm test is currently blocked locally on Node 20/Windows because node --test cannot load .ts test files directly and the package script passes tests/*.test.ts without a loader. I left that environment issue out of the implementation path.