cache(chain): return an error from Get when no caches are configured#309
Open
c-tonneslan wants to merge 1 commit into
Open
cache(chain): return an error from Get when no caches are configured#309c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
If a ChainCache is built with no underlying caches, Get returned the zero value of T with a nil error, which looks indistinguishable from a cache hit on a default-constructed value. ChainCache[[]byte].Get returned a zero-length []byte and no error. Guard the empty-caches case so callers see a real error. Closes eko#281 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a ChainCache is built with no underlying caches, `Get` returned the zero value of T with a nil error, which looks like a cache hit on a default-constructed value. `ChainCache[[]byte].Get` returned a zero-length `[]byte` and no error, so callers had no way to tell that nothing was actually cached.
Guard the empty-caches case so callers see a real error.
Closes #281.