Skip to content

added the type of validation failed to the error. also added a validateAll method that returns all the failed validation rules of a field. fixes issue #60#84

Open
WingmanImd wants to merge 2 commits into
eivindfjeldstad:masterfrom
WingmanImd:master

Conversation

@WingmanImd

Copy link
Copy Markdown

This change will just add the type property to the error.

@codecov

codecov Bot commented Feb 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #84 into master will decrease coverage by 10.13%.
The diff coverage is 10.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #84       +/-   ##
===========================================
- Coverage   98.67%   88.53%   -10.14%     
===========================================
  Files           6        6               
  Lines         226      253       +27     
===========================================
+ Hits          223      224        +1     
- Misses          3       29       +26
Impacted Files Coverage Δ
src/schema.js 89.1% <0%> (-10.9%) ⬇️
src/error.js 100% <100%> (ø) ⬆️
src/property.js 81.92% <11.76%> (-18.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106c2fb...1193afa. Read the comment docs.

@WingmanImd WingmanImd changed the title added the type of validation failed to the error added the type of validation failed to the error. also added a validateAll method that returns all the failed validation rules of a field Feb 19, 2019
@WingmanImd WingmanImd changed the title added the type of validation failed to the error. also added a validateAll method that returns all the failed validation rules of a field added the type of validation failed to the error. also added a validateAll method that returns all the failed validation rules of a field. fixes issue #60 Feb 19, 2019
@codecov-io

codecov-io commented Nov 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #84 into master will decrease coverage by 10.15%.
The diff coverage is 10.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #84       +/-   ##
===========================================
- Coverage   98.69%   88.53%   -10.16%     
===========================================
  Files           6        6               
  Lines         230      253       +23     
===========================================
- Hits          227      224        -3     
- Misses          3       29       +26
Impacted Files Coverage Δ
src/schema.js 89.1% <0%> (-10.9%) ⬇️
src/error.js 100% <100%> (ø) ⬆️
src/property.js 81.92% <11.76%> (-18.08%) ⬇️
src/validators.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cc1af...1193afa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants