Update mvpa-css to 524c8af (SMACSS fix, monochrome, float flash)#262
Merged
Conversation
Bump mvpa-css gem from bc9d982 to 524c8af. The new version floats flash messages as fixed-position toasts via [data-mvpa-flashes], so update all three layouts to wrap flashes in <output data-mvpa-flashes> with role on <aside>. Also corrects the stale data-theme value from selenized_light to solunized-light. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The mvpa-css upgrade moved flash messages to fixed-position toasts at top-right. This overlays the top navigation, causing Selenium click interception in system tests. Override to bottom-right so toasts are visible but don't block nav links. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
output carries an implicit role="status" which conflicts with the explicit role attributes on child asides, and is semantically wrong for a notification container. section is neutral and valid here. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Use section instead of output (output is semantically wrong for notifications). Wrap in flash.any? so the container is absent when there are no messages — avoids interfering with tests that count section elements on the page. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
mvpa-cssgem frombc9d982to524c8af. The new version restructures the SMACSS folder layout, adds@media (monochrome)support for e-ink displays, and changes flash messages to fixed-position toasts using a[data-mvpa-flashes]container.All three layouts are updated to use
<output data-mvpa-flashes>(semantic wrapper for live feedback) withrolemoved from<p>to<aside>, matching the new flash.css selectors. The staledata-theme="selenized_light"attribute is corrected tosolunized-light.