Feature/rework using plugin template#25
Conversation
There was a problem hiding this comment.
Not sure we need css and js checking in Orbit, as we dont currently use either.
The PHP run could be composer run lint instead, then no need to use node. Though perhaps it was just in case for future?
There was a problem hiding this comment.
I wasn't sure on this but thought it could be good as a future thing, though we don't have any plans with orbit that would likely involve this right now so it could always just be added when needed
There was a problem hiding this comment.
I have removed the css and js checking and node for now, we'll re-review down the line if the need for it arises rather than having it in for no reason currently
|
Overall looks great thanks @DanielHudson2. I had one query on Lefthook - I left a comment. |
Pluginclass where other classes are initialisedinitfunction within theirsetupfunction if necessary