Skip to content

Feature/rework using plugin template#25

Merged
brettsmason merged 9 commits into
mainfrom
feature/rework-using-plugin-template
Oct 24, 2025
Merged

Feature/rework using plugin template#25
brettsmason merged 9 commits into
mainfrom
feature/rework-using-plugin-template

Conversation

@DanielHudson2

Copy link
Copy Markdown
Member
  • Incorporated config files from new plugin template
  • Removed settings.js as it was for the old settings screen
  • Added main Plugin class where other classes are initialised
  • Rather than calling several classes from the 'init' hook in the main plugin file classes now call a separate init function within their setup function if necessary
  • Added more documentation of returns on functions

@DanielHudson2 DanielHudson2 added the enhancement New feature or request label Oct 23, 2025
@DanielHudson2 DanielHudson2 self-assigned this Oct 23, 2025
Comment thread lefthook.yml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need css and js checking in Orbit, as we dont currently use either.
The PHP run could be composer run lint instead, then no need to use node. Though perhaps it was just in case for future?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure on this but thought it could be good as a future thing, though we don't have any plans with orbit that would likely involve this right now so it could always just be added when needed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the css and js checking and node for now, we'll re-review down the line if the need for it arises rather than having it in for no reason currently

@brettsmason

Copy link
Copy Markdown
Member

Overall looks great thanks @DanielHudson2. I had one query on Lefthook - I left a comment.
GitHub Actions probably need updating too, but thats for another PR when we have settled on a test suite.

@brettsmason brettsmason merged commit 70dfcc7 into main Oct 24, 2025
1 check failed
@DanielHudson2 DanielHudson2 deleted the feature/rework-using-plugin-template branch October 30, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants